Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Java 11 upgrade #391

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

[WIP] Java 11 upgrade #391

wants to merge 7 commits into from

Commits on Jul 25, 2019

  1. Configuration menu
    Copy the full SHA
    5d7b2e2 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2019

  1. various library updates

    Tylerwbrown committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    de9763d View commit details
    Browse the repository at this point in the history
  2. Parameters update

    Tylerwbrown committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    36e0785 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2019

  1. gradle change

    Tylerwbrown committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    ea63491 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aac7f8f View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2019

  1. Changed way we retrieved the class path, more details below

    The old way we retrieved the classpath wasn't ever supported by Java, it was an implementation detail on the JVM that got removed in Java 9, even though Java 9 was "backwards compatible", it broke code that wasn't officially supported.
    Tylerwbrown committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    0013153 View commit details
    Browse the repository at this point in the history
  2. Changed some details about fork, details below

    - Used local variable type inference
    - Made use of final consistent
    - JavaApp already had a constructor that takes just the sourcecode and manages getting the classpath
    - Used Java 8+ lambda syntax over new Runnable() { ..run } syntax
    - Made variables more understandable. They were lacking context before that took a little too long to figure out on the first read, i.e:
        - is input the filepath or the data that'll go in the file?
        - is output the filepath or the data that'll go in the file?
        - is source the filepath or the data that'll go in the file?
    the answer was different for each of these but nothing about their names or type signified this, so I changed them. 
    Also "ret" isn't a good name.
    Tylerwbrown committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    0ee6162 View commit details
    Browse the repository at this point in the history