-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Java 11 upgrade #391
Open
Tylerwbrown
wants to merge
7
commits into
develop
Choose a base branch
from
feature/CON-631
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jul 25, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 5d7b2e2 - Browse repository at this point
Copy the full SHA 5d7b2e2View commit details
Commits on Jul 26, 2019
-
Configuration menu - View commit details
-
Copy full SHA for de9763d - Browse repository at this point
Copy the full SHA de9763dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36e0785 - Browse repository at this point
Copy the full SHA 36e0785View commit details
Commits on Jul 30, 2019
-
Configuration menu - View commit details
-
Copy full SHA for ea63491 - Browse repository at this point
Copy the full SHA ea63491View commit details -
Configuration menu - View commit details
-
Copy full SHA for aac7f8f - Browse repository at this point
Copy the full SHA aac7f8fView commit details
Commits on Aug 1, 2019
-
Changed way we retrieved the class path, more details below
The old way we retrieved the classpath wasn't ever supported by Java, it was an implementation detail on the JVM that got removed in Java 9, even though Java 9 was "backwards compatible", it broke code that wasn't officially supported.
Configuration menu - View commit details
-
Copy full SHA for 0013153 - Browse repository at this point
Copy the full SHA 0013153View commit details -
Changed some details about fork, details below
- Used local variable type inference - Made use of final consistent - JavaApp already had a constructor that takes just the sourcecode and manages getting the classpath - Used Java 8+ lambda syntax over new Runnable() { ..run } syntax - Made variables more understandable. They were lacking context before that took a little too long to figure out on the first read, i.e: - is input the filepath or the data that'll go in the file? - is output the filepath or the data that'll go in the file? - is source the filepath or the data that'll go in the file? the answer was different for each of these but nothing about their names or type signified this, so I changed them. Also "ret" isn't a good name.
Configuration menu - View commit details
-
Copy full SHA for 0ee6162 - Browse repository at this point
Copy the full SHA 0ee6162View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.