Add nameOverride and fullnameOverride support to Tetragon Helm chart #3604

cy83rc0llect0r · 2025-04-07T21:57:55Z

Enhancement #2951

Description

This pull request adds support for nameOverride and fullnameOverride in the Tetragon Helm chart, addressing the enhancement request in issue #2951. This feature allows users to customize the names of Kubernetes resources deployed via Helm, improving flexibility and compatibility in diverse environments (e.g., when deploying multiple instances or following naming conventions).

The changes include:

Addition of nameOverride and fullnameOverride fields to values.yaml.
Introduction of a new tetragon.fullname helper in _helpers.tpl to unify naming logic across templates.
Updates to all affected templates (DaemonSet, Deployment, ServiceAccount, etc.) to use the new helper instead of .Release.Name.
Tested the changes using helm template to validate correct name rendering.

These changes are fully backward compatible: if nameOverride and fullnameOverride are not set, the chart behaves as before.

Use Case Example

A user deploying multiple instances of Tetragon (e.g., in different namespaces or clusters) can now avoid resource name collisions by customizing the full names of the Kubernetes objects. This is especially useful in CI/CD pipelines or large multi-tenant setups where naming conventions must be enforced.

Changelog

Added nameOverride and fullnameOverride support to the Tetragon Helm chart. Use these fields in values.yaml to customize resource names.

netlify · 2025-04-07T21:58:52Z

✅ Deploy Preview for tetragon ready!

Name	Link
🔨 Latest commit	`95a7785`
🔍 Latest deploy log	https://app.netlify.com/projects/tetragon/deploys/682ef78b216b9000083204f0
😎 Deploy Preview	https://deploy-preview-3604--tetragon.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

cy83rc0llect0r · 2025-04-22T09:21:36Z

@tpapagian Could you please find some time to review my PR? It's been pending for a while, and your feedback would be greatly appreciated to move it forward.
Thank you for your time and support!

tpapagian · 2025-04-22T10:28:27Z

@tpapagian Could you please find some time to review my PR? It's been pending for a while, and your feedback would be greatly appreciated to move it forward. Thank you for your time and support!

Hey, sorry missed that review. This PR looks good to me. Thanks!

mtardy · 2025-04-23T08:47:23Z

install/kubernetes/tetragon/templates/operator_clusterrolebinding.yaml

-    name: {{ include "tetragon-operator.serviceAccount" . }}
+    name: {{ include "tetragon.fullname" . }}-operator-service-account


here you don't use the tetragon-operator.serviceAccount name anymore, it seems it was missing the .name but maybe we still want that to work?

@mtardy Thanks for the review! I understand you're concerned about switching from tetragon-operator.serviceAccount to tetragon.fullname for the serviceAccount name in operator_deployment.yaml and operator_serviceaccount.yaml. With the current setup, the serviceAccount name is tetragon-operator-service-account by default, and it changes to custom-operator-service-account when nameOverride=custom is set, which works correctly with RBAC (e.g., custom-operator-rolebinding).
To clarify, do you want the serviceAccount name to always remain tetragon-operator-service-account (regardless of nameOverride or fullnameOverride) to ensure compatibility with existing configurations? Or is the current behavior, where the name can change with nameOverride, acceptable? I can revert to tetragon-operator.serviceAccount and lock the name if needed.

Any comments? @mtardy

So as I understand this value is defined as such, if you have .Values.tetragonOperator.serviceAccount.name we use it otherwise it default to what you said.

{{- define "tetragon-operator.serviceAccount" -}} {{- if .Values.tetragonOperator.serviceAccount.name -}} {{- printf "%s" .Values.tetragonOperator.serviceAccount.name -}} {{- else -}} {{- printf "%s-operator-service-account" .Release.Name -}} {{- end -}} {{- end }}

So perhaps what you want to do in this PR is to change

- {{- printf "%s-operator-service-account" .Release.Name -}} + {{ include "tetragon.fullname" . }}-operator-service-account

In this template no? Otherwise the value will be ignored

you might want to change tetragon's serviceaccount as well, it seems you skipped that:

{{/* ServiceAccounts */}} {{- define "tetragon.serviceAccount" -}} {{- if .Values.serviceAccount.name -}} {{- printf "%s" .Values.serviceAccount.name -}} {{- else -}} {{- printf "%s" .Release.Name -}} {{- end -}} {{- end }}

In the _helpers.tpl

Maybe grep for .Release.Name for the remaining stuff.

mtardy · 2025-04-23T08:48:17Z

install/kubernetes/tetragon/templates/operator_deployment.yaml

@@ -98,12 +98,12 @@ spec:
      tolerations:
        {{- toYaml . | nindent 8 }}
      {{- end }}
-      serviceAccountName: {{ include "tetragon-operator.serviceAccount" . }}


mtardy · 2025-04-23T08:48:27Z

install/kubernetes/tetragon/templates/operator_serviceaccount.yaml

@@ -2,7 +2,7 @@
 apiVersion: v1
 kind: ServiceAccount
 metadata:
-  name: {{ include "tetragon-operator.serviceAccount" . }}


mtardy · 2025-04-30T12:11:40Z

Aside I'll be off for the next two weeks, so feel free to ping someone else if you want to merge this earlier

cy83rc0llect0r · 2025-05-21T20:35:42Z

My bad!
I accidentally created a wrong push and closed my PR!
Can you remove this and I will create new PR?
@mtardy

mtardy · 2025-05-22T08:02:57Z

Can you remove this and I will create new PR?
@mtardy

Hey, what would you like to remove? This PR seems to be closed already.

cy83rc0llect0r · 2025-05-22T08:05:10Z

Can you remove this and I will create new PR?
@mtardy

Hey, what would you like to remove? This PR seems to be closed already.

Yes it closed by my mistake :(

mtardy · 2025-05-22T08:13:16Z

Can you remove this and I will create new PR?
@mtardy

Hey, what would you like to remove? This PR seems to be closed already.

Yes it closed by my mistake :(

I think you might be able to reopen it if you push commit to the branch again

- Added nameOverride and fullnameOverride fields to values.yaml at root level for customizable resource names. - Introduced tetragon.fullname helper in _helpers.tpl to standardize naming across the chart. - Updated all templates to use tetragon.fullname instead of .Release.Name for consistency in resources (DaemonSet, Deployment, ServiceAccount, etc.). - Tested with helm template to ensure correct name rendering." Enhancement cilium#2951 Signed-off-by: Amir Reza Nazarizadeh <[email protected]>

cy83rc0llect0r · 2025-05-26T10:04:41Z

@mtardy Could you please check my changes?

mtardy

hey I don't understand your changes, are you using an LLM to generate those patches?

mtardy · 2025-05-26T10:51:15Z

install/kubernetes/tetragon/templates/operator_serviceaccount.yaml

-{{- if and .Values.tetragonOperator.enabled .Values.tetragonOperator.serviceAccount.create -}}
+{{- if and .Values.tetragonOperator.serviceAccount.create }}


I don't get why you removed that?

mtardy · 2025-05-26T10:51:28Z

install/kubernetes/tetragon/templates/serviceaccount.yaml

-{{- if .Values.serviceAccount.create -}}
+{{- if .Values.serviceAccount.create }}


mtardy · 2025-05-26T10:55:24Z

install/kubernetes/tetragon/templates/_container_oci_hooks_setup.tpl

sorry but what is this?

mtardy · 2025-05-26T10:57:00Z

install/kubernetes/tetragon/templates/_helpers.tpl

 {{- define "rthooksInterface" -}}
 {{ $iface := .Values.rthooks.interface }}
 {{- if (eq $iface "oci-hooks") -}}
-	oci-hooks
+        oci-hooks


should we use space? why the empty line removals?

mtardy · 2025-05-26T11:00:27Z

install/kubernetes/tetragon/templates/clusterrolebinding.yml

  labels:
-  {{- include "tetragon.labels" . | nindent 4 }}
+    {{- include "tetragon.labels" . | nindent 4 }}


is this expected?

cy83rc0llect0r · 2025-05-26T11:08:40Z

hey I don't understand your changes, are you using an LLM to generate those patches?

No I didn't. I was working on another PR for Tetragon and I think everything was messed up. Let me clean it up.

cy83rc0llect0r · 2025-05-26T11:26:06Z

@mtardy

To be honest, I felt quite disheartened and lost some focus after seeing the assumption that I might have used an LLM to patch my code. I understand that the code might appear a bit messy or unexpected, but this is primarily due to the long time gap between opening this PR and today, which has led to a lack of proper focus on this particular fork.
Given this, I prefer to either close this Pull Request or convert it to a DRAFT.

Thank you so much.

mtardy · 2025-05-26T14:01:31Z

To be honest, I felt quite disheartened and lost some focus after seeing the assumption that I might have used an LLM to patch my code. I understand that the code might appear a bit messy or unexpected, but this is primarily due to the long time gap between opening this PR and today, which has led to a lack of proper focus on this particular fork.
Given this, I prefer to either close this Pull Request or convert it to a DRAFT.

yeah sorry it's just that it happened in the past and because I saw some random changes I thought it was that again, sorry it was indelicate! The PR is helpful

cy83rc0llect0r requested a review from a team as a code owner April 7, 2025 21:57

cy83rc0llect0r requested a review from tpapagian April 7, 2025 21:57

mtardy added the release-note/minor This PR introduces a minor user-visible change label Apr 15, 2025

cy83rc0llect0r force-pushed the pr/cy83rc0llect0r/add-nameOverride-to-helm-chart branch from fcd9f30 to 85476ec Compare April 15, 2025 09:10

tpapagian approved these changes Apr 22, 2025

View reviewed changes

mtardy reviewed Apr 23, 2025

View reviewed changes

cy83rc0llect0r closed this May 21, 2025

cy83rc0llect0r force-pushed the pr/cy83rc0llect0r/add-nameOverride-to-helm-chart branch from 85476ec to e786762 Compare May 21, 2025 20:26

cy83rc0llect0r reopened this May 22, 2025

cy83rc0llect0r force-pushed the pr/cy83rc0llect0r/add-nameOverride-to-helm-chart branch from 95a7785 to a0c015f Compare May 22, 2025 10:18

mtardy requested changes May 26, 2025

View reviewed changes

mtardy reviewed May 26, 2025

View reviewed changes

cy83rc0llect0r marked this pull request as draft May 26, 2025 11:26

		name: {{ include "tetragon-operator.serviceAccount" . }}
		name: {{ include "tetragon.fullname" . }}-operator-service-account

		{{- if and .Values.tetragonOperator.enabled .Values.tetragonOperator.serviceAccount.create -}}
		{{- if and .Values.tetragonOperator.serviceAccount.create }}

		{{- if .Values.serviceAccount.create -}}
		{{- if .Values.serviceAccount.create }}

Add nameOverride and fullnameOverride support to Tetragon Helm chart #3604

Are you sure you want to change the base?

Add nameOverride and fullnameOverride support to Tetragon Helm chart #3604

Uh oh!

Conversation

cy83rc0llect0r commented Apr 7, 2025

Description

Use Case Example

Changelog

Uh oh!

netlify bot commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for tetragon ready!

Uh oh!

cy83rc0llect0r commented Apr 22, 2025

Uh oh!

tpapagian commented Apr 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cy83rc0llect0r Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mtardy commented Apr 30, 2025

Uh oh!

cy83rc0llect0r commented May 21, 2025

Uh oh!

mtardy commented May 22, 2025

Uh oh!

cy83rc0llect0r commented May 22, 2025

Uh oh!

mtardy commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cy83rc0llect0r commented May 26, 2025

Uh oh!

mtardy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mtardy May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cy83rc0llect0r commented May 26, 2025

Uh oh!

cy83rc0llect0r commented May 26, 2025

Uh oh!

mtardy commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Apr 7, 2025 •

edited

Loading

cy83rc0llect0r Apr 23, 2025 •

edited

Loading

mtardy commented May 22, 2025 •

edited

Loading

mtardy May 26, 2025 •

edited

Loading

mtardy commented May 26, 2025 •

edited

Loading