Add percpu buffer flag #552
Conversation
|
Thanks for the PR. Unfortunately, we cannot use variable length arrays. One solution would be to use a BPF map with value Please let me know if you are comfortable to implement the solution above. |
|
What do you mean by agent exactly? |
|
The Go userspace process (main.go) |
|
@ti-mo suggested:
|
AdvH039
force-pushed
the
buff-size-flag
branch
2 times, most recently
from
ad2b4f3 to
4e48b06
Compare
internal/pwru/types.go
Outdated
| @@ -110,6 +112,7 @@ func (f *Flags) SetFlags() { | |||
| flag.StringVar(&f.Backend, "backend", "", | |||
| fmt.Sprintf("Tracing backend('%s', '%s'). Will auto-detect if not specified.", BackendKprobe, BackendKprobeMulti)) | |||
|
|
|||
| flag.Uint32Var(&f.SetPerCPUBuf, "set-percpu-buf", 4096, "set the size of the percpu buffer") | |||
There was a problem hiding this comment.
Maybe you could be more specific with the flag description? I.e. instead of saying "percpu buffer", you could say "set the size of buffers to print skb data (used by --output-skb and --output-skb-shared-info)".
Signed-off-by: Adv <[email protected]>
Tries to fix #508
(Edit : What command to use for linting?)