Replace internal.NativeEndian with stdlib #1669
Open
+133
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejedi
requested review from
dylandreimerink,
florianl and
a team
as code owners
mejedi
force-pushed
the
switch-to-binary-nativeendian
branch
from
ec4f104 to
bf868b1
Compare
mejedi
force-pushed
the
switch-to-binary-nativeendian
branch
4 times, most recently
from
46516de to
dfa9d1a
Compare
Yet another attempt at replacing internal.NativeEndian with NativeEndian
from "encoding/binary". The conversion is mostly a straight-forward
replacement. The only challenge are checks whether a ByteOrder is
Big/Little/NativeEndian. In stdlib, NativeEndian is a distinct type
hence never compares equal to BigEndian or LittleEndian.
Introduce internal.EqualByteOrder(bo1, bo2). It works by passing
[]byte{0x12, 0x34} through bo1.Uint16() and bo2.Uint16() and comparing
the results.
Signed-off-by: Nick Zavaritsky <[email protected]>
mejedi
force-pushed
the
switch-to-binary-nativeendian
branch
from
dfa9d1a to
2ea765f
Compare
mejedi
commented
Feb 5, 2025
Comment on lines
+5
to
+19
| func endianMark(bo binary.ByteOrder) uint16 { return bo.Uint16([]byte{0x12, 0x34}) } | ||
|
|
||
| func EqualByteOrder(bo1, bo2 binary.ByteOrder) bool { | ||
| return endianMark(bo1) == endianMark(bo2) | ||
| } | ||
|
|
||
| func NormalizeByteOrder(bo binary.ByteOrder) binary.ByteOrder { | ||
| if EqualByteOrder(bo, binary.BigEndian) { | ||
| return binary.BigEndian | ||
| } | ||
| if EqualByteOrder(bo, binary.LittleEndian) { | ||
| return binary.LittleEndian | ||
| } | ||
| return bo | ||
| } |
There was a problem hiding this comment.
One might argue that EqualByteOrder is not stringent enough. Indeed, one can implement e.g. PDPEndian. EqualByteOrder will claim that PDPEndian is equal to LittleEndian.
However, there's neither Golang nor eBPF available on PDP 11. "Weird" byte orders are probably just a theoretical concern.
There was a problem hiding this comment.
Yea, I think this is good enough. I do not expect PDP 11 related issues :)
dylandreimerink
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another attempt at replacing
internal.NativeEndianwithNativeEndianfrom"encoding/binary". The conversion is mostly a straight-forward replacement. The only challenge are checks whether a ByteOrder is Big/Little/NativeEndian. In stdlib, NativeEndian is a distinct type hence never compares equal to BigEndian or LittleEndian.Introduce
internal.EqualByteOrder(bo1, bo2). It works by passing[]byte{0x12, 0x34}throughbo1.Uint16()andbo2.Uint16()and comparing the results.