feat: add between function to Date module #951
Merged
+125
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #937
Added two
between
functions to theDate
module, like: https://fakerjs.dev/api/date.html#betweenOne function to support two
ISO
Dates:std::string between(std::string from, std::string to, DateFormat dateFormat)
One function to support two
Timestamps
:Made sure to write tests that cover edge cases, and added docs.
Testing
Automated
Run tests, and make sure they pass
Manual
Build and use
faker
in somecpp
file and try out the new functions yourself, i.e.:and