Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bigInt function with comprehensive tests #949

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Daniel-Grounin
Copy link

This PR introduces the implementation of the bigInt function in the Number module.

  • Added support for generating random BigInt numbers within a specific range.
  • Updated unit tests to cover various scenarios, including valid ranges, negative ranges, and edge cases like same min and max values.
  • All tests were run and passed successfully.

Please review the changes and let me know if there are any adjustments needed. Thank you!

  • Fixed line-ending issues (CRLF/LF) that were causing changes across all lines of the files, making it hard to review. Now, only the necessary changes are visible in the diff.

@@ -4,6 +4,7 @@
#include <optional>
#include <random>
#include <stdexcept>
#include <optional>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional is already included above

@cieslarmichal cieslarmichal linked an issue Oct 5, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add bigInt function to Number module
2 participants