chore: added weather descriptions #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
00thirdeye00
commented
Sep 10, 2024
00thirdeye00
commented
- swedish weather descriptions added to weather module
* swedish weather descriptions added to weather module Signed-off-by: Guru Mehar Rachaputi <[email protected]>
cieslarmichal
requested changes
Sep 11, 2024
* added locale to weather module and changed the weather function definition Signed-off-by: Guru Mehar Rachaputi <[email protected]>
cieslarmichal
requested changes
Sep 12, 2024
|
hello @00thirdeye00 whats the situation here? |
* added parameterized test to weather module Signed-off-by: Guru Mehar Rachaputi <[email protected]>
cieslarmichal
approved these changes
Sep 27, 2024
* weather module test case fixed Signed-off-by: Guru Mehar Rachaputi <[email protected]>
cieslarmichal
approved these changes
Sep 27, 2024
This was
linked to
issues
Sep 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.