Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add between function to Date module #937

Closed
cieslarmichal opened this issue Oct 3, 2024 · 7 comments · Fixed by #951
Closed

add between function to Date module #937

cieslarmichal opened this issue Oct 3, 2024 · 7 comments · Fixed by #951
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@cieslarmichal
Copy link
Owner

like https://fakerjs.dev/api/date.html#between

@cieslarmichal cieslarmichal added the good first issue Good for newcomers label Oct 3, 2024
@cieslarmichal cieslarmichal added this to the v4.0.0 milestone Oct 3, 2024
@tonykcao
Copy link
Contributor

tonykcao commented Oct 4, 2024

I believe we have this already? betweenDate in date.cpp

@cieslarmichal
Copy link
Owner Author

There is no API for this in header file its just internal function, so users cannot use it. The new public API should work probably with two timestamps or iso dates :)

@cieslarmichal
Copy link
Owner Author

I have assigned you.

@tonykcao tonykcao removed their assignment Oct 4, 2024
@tonykcao
Copy link
Contributor

tonykcao commented Oct 4, 2024

Hi! I'll be taking some time off soon, someone else feel free to take this in the mean time!

@cieslarmichal
Copy link
Owner Author

Ok :)

@Mounayer
Copy link
Contributor

Mounayer commented Oct 7, 2024

Hello, I could give this issue a try!

@cieslarmichal
Copy link
Owner Author

Ok, assigned :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants