Change ciel feature to ciel-script #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccqpein
commented
Sep 17, 2024
| @@ -226,7 +226,7 @@ | |||
| ((and (first args) | |||
| (uiop:file-exists-p (first args))) | |||
| ;; Add a symbol in the feature list, so a script knows when it is being executed. | |||
| (push :ciel ciel-user::*features*) | |||
| (push :ciel-script ciel-user::*features*) | |||
There was a problem hiding this comment.
I think this is the :ciel-script right? Not :ciel
|
Hi, so did you push the Also… please can we name them in reverse: add |
|
@vindarel I didn't. I noticed there is only |
|
If you have the need for it, you can add a But we don't need to rename ":ciel" to ":ciel-script". thanks |
|
That’s make sense. It might be easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this comment