Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ciel feature to ciel-script #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ccqpein
Copy link
Contributor

@ccqpein ccqpein commented Sep 17, 2024

Related to this comment

@@ -226,7 +226,7 @@
((and (first args)
(uiop:file-exists-p (first args)))
;; Add a symbol in the feature list, so a script knows when it is being executed.
(push :ciel ciel-user::*features*)
(push :ciel-script ciel-user::*features*)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the :ciel-script right? Not :ciel

@vindarel
Copy link
Contributor

Hi, so did you push the :ciel features in the non-script file?

Also… please can we name them in reverse: add :ciel-user and let's keep :ciel for the scripts. Sorry for the back and forth :D

@ccqpein
Copy link
Contributor Author

ccqpein commented Sep 18, 2024

@vindarel I didn't. I noticed there is only :ciel feature. So you mean add the :ciel feature to other package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants