Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/legend filter #238

Open
wants to merge 36 commits into
base: beta
Choose a base branch
from
Open

Feature/legend filter #238

wants to merge 36 commits into from

Conversation

romsson
Copy link
Collaborator

@romsson romsson commented Apr 5, 2016

screen shot 2016-04-05 at 3 20 49 pm

  • Filters the VisTK scatterplot based on legend's product category being clicked
  • The legend visually reflects the current selection by highlighting the currently selected product
  • The filter can be disabled by clicking on the currently selected legend key
  • Current version does not support time change, text filter, page refresh, and also does not filter the table

@romsson
Copy link
Collaborator Author

romsson commented Apr 8, 2016

network

  • Code cleanup
  • Works for network visualization

@makmanalp makmanalp force-pushed the feature/legend-filter branch from 0d075ec to 562a9a6 Compare April 11, 2016 20:13
@makmanalp
Copy link
Contributor

Rebasing the commits on top of latest changes to review properly.

@makmanalp
Copy link
Contributor

So the filtering works great as far as I can see, but there is some trouble with tooltips after the filter is removed, e.g in industry scatters:

scatter_legends_lag2

and another example with product ones where suddenly it behaves strangely after the filtering is removed:

scatter_legends_lag

It's almost like the filter remains for the tooltip/hover even after it's been removed and the other nodes are visible.


Also, we probably should call this out of scope for this ticket, but it'd be cool to make it obvious that the legend is clickable.

@makmanalp
Copy link
Contributor

Also, there is a build error that seems relevant (https://circleci.com/gh/cid-harvard/atlas-subnational-frontend/669): "TypeError: undefined is not an object (evaluating 'keyFilter.length')" when you go to the country profile.

@gregshap
Copy link
Collaborator

Good catch @makmanalp

One other small thing: when filtering the product space, its very hard to see the difference between the products that this place does vs does not do

@@ -129,7 +138,10 @@ export default Ember.Component.extend({
translate: [0, -10]
}]
}]
});
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JShint complaining about a missing semicolon here

@makmanalp
Copy link
Contributor

So @romsson it's still the same trouble for me: after filtering by a category and removing the filter, the tooltip only shows for the previously filtered category (and starts becoming laggy but that's less of a concern right now).

E.g. see after I filter by chemicals and undo the filter, how the purple ones are the only ones that have tooltips:

scatter_legends_lag3

@QuinnLee
Copy link
Contributor

QuinnLee commented May 6, 2016

@makmanalp we should rebase these frequently so we don't loose the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants