Updating parent element to be destination element

cibernox · Jun 27, 2021 · f5ba32e · f5ba32e
1 parent 821852e
commit f5ba32e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/addon/components/basic-dropdown-content.ts b/addon/components/basic-dropdown-content.ts
@@ -126,11 +126,7 @@ export default class BasicDropdownContent extends Component<Args> {
   animateOut(dropdownElement: Element): void {
     if (!this.animationEnabled) return;
     this.animationClass = this.transitioningInClass;
-    let parentElement = dropdownElement.parentElement;
-    if (parentElement === null) return;
-    if (this.args.renderInPlace) {
-      parentElement = parentElement.parentElement
-    }
+    let parentElement = this.destinationElement;
     if (parentElement === null) return;
     let clone = dropdownElement.cloneNode(true) as Element;
     clone.id = `${clone.id}--clone`;

diff --git a/addon/templates/components/basic-dropdown-content.hbs b/addon/templates/components/basic-dropdown-content.hbs
@@ -1,6 +1,6 @@
 {{! template-lint-disable no-inline-styles }}
 {{#if @dropdown.isOpen}}
-  <div class="ember-basic-dropdown-content-wormhole-origin">
+  <div class={{if @dropdown.isOpen "ember-basic-dropdown-content-wormhole-origin" "ember-basic-dropdown-content-placeholder"}}>
     {{#maybe-in-element this.destinationElement @renderInPlace}}
       {{#if @overlay}}
         <div class="ember-basic-dropdown-overlay"></div>