Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace linked_hash_map with hashlink #157

Closed
wants to merge 1 commit into from
Closed

replace linked_hash_map with hashlink #157

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented May 26, 2020

Change-Id: I40abd6d7e7d266af312cd110a64a3f0fcc669c88
@chyh1990
Copy link
Owner

chyh1990 commented Jun 1, 2020

it seems that linked-hash-map is quite stable (and used by several popular crates), and we have no reason the switch to a new crate.

@chyh1990 chyh1990 mentioned this pull request Jun 2, 2020
@niluxv
Copy link

niluxv commented Jul 11, 2020

linked-hash-map triggers UB (detected by miri). See the issue you linked and this issue at rustbreak(which has linked-hash-map only as a transitive dependency through this crate and serde_yaml and already triggers UB in the testsuite).

@dessalines
Copy link

Since linked_hash_map is broken on rust 1.48.0, and this is affecting downstream projects, this is pressing.

@dessalines
Copy link

Any movement on this? This has been preventing projects from using newer rust versions for 2 months now.

@ghost ghost closed this by deleting the head repository Jan 28, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants