Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): enable offset reset before consuming from kafka #38

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

KarimGl
Copy link
Contributor

@KarimGl KarimGl commented Mar 15, 2024

Issue Number

fixes #

Describe the changes you've made

When consuming from kafka withresetOffset=true, the group offset is reset to the beginning.

Describe if there is any unusual behaviour of your code

Additional context

Test plan

Checklist

  • Refer to issue(s) the PR solves
  • New java code is covered by tests
  • Add screenshots or gifs of the new behavior, if applicable.
  • All new and existing tests pass
  • No git conflict

@nbrouand nbrouand added the enhancement New feature or request label Mar 18, 2024
DelaunayAlex
DelaunayAlex previously approved these changes Mar 18, 2024
nbrouand
nbrouand previously approved these changes Mar 18, 2024
boddissattva
boddissattva previously approved these changes Mar 19, 2024
@KarimGl KarimGl dismissed stale reviews from boddissattva, nbrouand, and DelaunayAlex via d57feda March 19, 2024 17:06
@KarimGl KarimGl force-pushed the feat/kafka branch 3 times, most recently from 376015d to 82e665e Compare March 20, 2024 11:17
boddissattva
boddissattva previously approved these changes Mar 21, 2024
nbrouand
nbrouand previously approved these changes Mar 21, 2024
@KarimGl KarimGl dismissed stale reviews from nbrouand and boddissattva via a4d12e1 March 25, 2024 17:01
@KarimGl KarimGl requested a review from rbenyoussef March 26, 2024 15:53
@KarimGl KarimGl merged commit 272d7b2 into main Mar 28, 2024
2 checks passed
@KarimGl KarimGl deleted the feat/kafka branch March 28, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants