Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow build with TestContainers' test for kotlin-dsl on docker in WSL2 without desktop #37

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Allow build with TestContainers' test for kotlin-dsl on docker in WSL2 without desktop #37

merged 1 commit into from
Mar 19, 2024

Conversation

boddissattva
Copy link
Member

Checklist

  • Refer to issue(s) the PR solves
  • New java code is covered by tests
  • Add screenshots or gifs of the new behavior, if applicable.
  • All new and existing tests pass
  • No git conflict

@boddissattva boddissattva added the technical Technical enhancements label Mar 15, 2024
@boddissattva
Copy link
Member Author

Test done on Windows with :

  • docker with "manual" WSL2 (Ubuntu) without docker desktop
  • docker with docker desktop

@boddissattva boddissattva self-assigned this Mar 15, 2024
@nbrouand nbrouand merged commit dc06444 into main Mar 19, 2024
1 check passed
@nbrouand nbrouand deleted the chore/fix-kotlin-build-docker-wsl2 branch March 19, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbrouand nbrouand nbrouand approved these changes

@KarimGl KarimGl KarimGl approved these changes

@DelaunayAlex DelaunayAlex DelaunayAlex approved these changes

@bessonm bessonm Awaiting requested review from bessonm

@rbenyoussef rbenyoussef Awaiting requested review from rbenyoussef

Assignees

@boddissattva boddissattva

Labels
technical Technical enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@boddissattva @nbrouand @KarimGl @DelaunayAlex