Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): get campaign fetches executions from db #32

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

KarimGl
Copy link
Contributor

@KarimGl KarimGl commented Mar 5, 2024

Issue Number

fixes #

Describe the changes you've made

Get campaign running execution from db instead of in-memory cache.
Why? to get the exact scenario execution Id.

Describe if there is any unusual behaviour of your code

Additional context

Test plan

Checklist

  • Refer to issue(s) the PR solves
  • New java code is covered by tests
  • Add screenshots or gifs of the new behavior, if applicable.
  • All new and existing tests pass
  • No git conflict

@KarimGl KarimGl requested review from nbrouand and DelaunayAlex March 5, 2024 16:17
nbrouand
nbrouand previously approved these changes Mar 5, 2024
@KarimGl KarimGl force-pushed the fix/running-exec branch from 188dcb8 to 3a5c6b8 Compare March 7, 2024 09:21
@KarimGl KarimGl changed the title fix(server): get running campaign executions from db fix(server): get campaign fetchs executions from db Mar 7, 2024
boddissattva
boddissattva previously approved these changes Mar 8, 2024
@boddissattva boddissattva self-requested a review March 8, 2024 08:15
@boddissattva
Copy link
Member

On running campaign execution page detail, the scenarios' executions list seems to be wrong ordered. The first scenario execution is at the bottom. It was the case before.

@nbrouand nbrouand added the bug Something isn't working label Mar 11, 2024
@KarimGl KarimGl changed the title fix(server): get campaign fetchs executions from db fix(server): get campaign fetches executions from db Mar 11, 2024
@KarimGl KarimGl dismissed stale reviews from boddissattva and nbrouand via 7daafb7 March 11, 2024 14:51
@nbrouand nbrouand merged commit b9021b7 into main Mar 12, 2024
2 checks passed
@nbrouand nbrouand deleted the fix/running-exec branch March 12, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants