Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header trailing whitespace issue with xml export #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

segeeslice
Copy link

Problem

When running the excel builder, an error would appear within XML Stringify, stating there was an improper header name.

Source

Upon investigation, the element names in question that caused the issue were 'fileVersion ' and 'workbookView '.

Looking at the regex in the XML package, these should not have the spaces in it to work as intended. I presume the XML package has updated at some point to not allow for these spaces.

Solution

Changed these headers to not include the trailing space.

@segeeslice
Copy link
Author

Admittedly, I have not researched much on the coding practices of this package. I would be glad to add the changes anywhere else as necessary.

@robert1233
Copy link

Would like a merge on this if possible @chuanyi . Removing those two spaces fixes it right up.

@pietersv
Copy link

@robert1233 Can you see if this works on branch https://github.com/protobi/msexcelbuilder and if not file a similar PR?

@robert1233
Copy link

That works as far as the above issue is concerned! @pietersv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants