Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-blob serde #1219

Closed
wants to merge 1 commit into from
Closed

Conversation

pinkforest
Copy link

Fixes #1218

I've been advocating to get serde to do the binary blobs opt-in basis but at best there will be opt-out at top bin level only :(

This will restrict the max version to ensure only serde without binary blobs gets pulled

Crates time and rust-analyzer have already done this and rand etc. may follow as well soon.

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #1219 (0d13243) into 0.4.x (0be4e7c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            0.4.x    #1219   +/-   ##
=======================================
  Coverage   86.14%   86.14%           
=======================================
  Files          37       37           
  Lines       13394    13394           
=======================================
  Hits        11538    11538           
  Misses       1856     1856           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pitdicker
Copy link
Collaborator

Downstream users can choose to restrict the maximum version of a dependency, this does not have to be done in chrono. Let's leave the choice up to them.

@pitdicker pitdicker closed this Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants