Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use regex-lite for chrono-tz-build #170

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use regex-lite for chrono-tz-build #170

wants to merge 1 commit into from

Conversation

djc
Copy link
Member

@djc djc commented Apr 15, 2024

We don't need a featureful or high-performance parser for the build script.

@djc djc requested a review from pitdicker April 15, 2024 20:41
@pitdicker
Copy link
Contributor

There has been some performance tuning in the past. Maybe the benchmark example is useful to compare?

@djc
Copy link
Member Author

djc commented Apr 15, 2024

Note that this does not change the dependency for the parse-zoneinfo crate -- only for the chrono-tz-build crate, which I think is only used for the filter-by-regex feature to filter timezone names.

Copy link
Contributor

@pitdicker pitdicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it was a comment without looking closely.

The principal difference between the regex and regex-lite crates is that the latter prioritizes smaller binary sizes and shorter Rust compile times over performance and functionality.

Locally with a CHRONO_TZ_TIMEZONE_FILTER and the filter-by-regex feature it saves 1% of the build time. I don't see much of an advantage t.b.h.

@djc
Copy link
Member Author

djc commented Apr 22, 2024

Going to wait until after #172.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants