Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review snippets to address from @davidben #400

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Code review snippets to address from @davidben #400

wants to merge 1 commit into from

Commits on Oct 13, 2023

  1. Code review snippets to address from @davidben 

    Also:
* sus_if_msvc for attributes should be sus_if_msvc_not_cl
  * "language is msvc variant" vs "compiler is msvc"
  * sus_if_gnuc_language
* test wrapping for each integer size, esp < 32bit
* not destroy nevervalue? since it's in a union can that be a
  requirement on NeverValueTypes, and is C++ okay with constructing
  an object in a place where one already exists and was not destroyed?
    @danakj
    danakj committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    2c4c226 View commit details
    Browse the repository at this point in the history