Skip to content

[1.15] Fix sh not returning results #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 1.13
Choose a base branch
from
Open

[1.15] Fix sh not returning results #689

wants to merge 1 commit into from

Conversation

xushulang
Copy link

Some Linux distributions use dash as the default sh, but in "dash", "command -v" only supports a single argument.

@GrahamCampbell
Copy link
Member

Thanks for reporting this. Are you able to replicate this not working, with a test?

@GrahamCampbell
Copy link
Member

Are there any downsides to making this change?

@GrahamCampbell GrahamCampbell changed the title Fix sh not returning results [1.15] Fix sh not returning results May 26, 2025
@xushulang
Copy link
Author

xushulang commented May 29, 2025 •
edited
Loading

Thanks for reporting this. Are you able to replicate this not working, with a test?

tested already

docker, php:8.4-fpm
image

@xushulang
Copy link
Author

Are there any downsides to making this change?

no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xushulang @GrahamCampbell