Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't auto-expand build eyebrow when canceling build #315

Merged
merged 3 commits into from
May 31, 2024

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented May 28, 2024

Only auto-expand on build error, not when build is aborted.

📦 Published PR as canary version: 1.5.1--canary.315.18cebad.0

✨ Test out this PR locally via:

npm install @chromatic-com/[email protected]
# or 
yarn add @chromatic-com/[email protected]

@ghengeveld ghengeveld linked an issue May 28, 2024 that may be closed by this pull request
@ghengeveld ghengeveld requested a review from thafryer May 28, 2024 14:15
@ghengeveld ghengeveld added skip-release Auto: Preserve the current version when merged patch Auto: Increment the patch version when merged labels May 28, 2024
Copy link
Member

@thafryer thafryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ghengeveld ghengeveld merged commit 672765e into main May 31, 2024
9 of 10 checks passed
@ghengeveld ghengeveld deleted the 245-progress-bar-shouldnt-automatically-expand branch May 31, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress bar shouldn't automatically expand
2 participants