Suggest setting onlyChanged: true, and only suggest config updates wh…

…en they're not explicitly set already
chromaui · May 14, 2024 · 7d1ae70 · 7d1ae70
1 parent d65f7c8
commit 7d1ae70
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/src/components/Screen.stories.tsx b/src/components/Screen.stories.tsx
@@ -29,7 +29,6 @@ export const Default: Story = {};
 const configuration = {
   configFile: "chromatic.config.json",
   projectId: "Project:6480e1b0042842f149cfd74c",
-  onlyChanged: true,
   externals: ["public/**"],
   autoAcceptChanges: "main",
   exitOnceUploaded: true,
@@ -40,7 +39,7 @@ export const Configuration: Story = {
     withSharedState(CONFIG_INFO, {
       configuration,
       problems: { storybookBaseDir: "src/frontend" },
-      suggestions: { zip: true },
+      suggestions: { onlyChanged: true, zip: true },
     } satisfies ConfigInfoPayload),
   ],
   parameters: {
@@ -55,7 +54,6 @@ export const ConfigurationProblems = {
     withSharedState(CONFIG_INFO, {
       configuration,
       problems: { storybookBaseDir: "src/frontend" },
-      suggestions: { zip: true },
     }),
   ],
 } satisfies StoryObj<typeof meta>;
@@ -65,7 +63,7 @@ export const ConfigurationSuggestions = {
     withSetup(() => localStorage.removeItem(CONFIG_INFO_DISMISSED)),
     withSharedState(CONFIG_INFO, {
       configuration,
-      suggestions: { zip: true },
+      suggestions: { onlyChanged: true, zip: true },
     }),
   ],
 } satisfies StoryObj<typeof meta>;

diff --git a/src/preset.ts b/src/preset.ts
@@ -93,7 +93,11 @@ const getConfigInfo = async (
     problems.storybookConfigDir = configDir;
   }
 
-  if (!configuration.zip) {
+  if (configuration.onlyChanged === undefined) {
+    suggestions.onlyChanged = true;
+  }
+
+  if (configuration.zip === undefined) {
     suggestions.zip = true;
   }
 
@@ -181,7 +185,6 @@ async function serverChannel(channel: Channel, options: Options & { configFile?:
         ...config,
         ...problems,
         ...suggestions,
-        onlyChanged: true,
         projectId,
       });
 

diff --git a/src/screens/VisualTests/Configuration.tsx b/src/screens/VisualTests/Configuration.tsx
@@ -302,7 +302,7 @@ export const Configuration = ({ onClose }: ConfigurationProps) => {
         <CloseIcon aria-label="Close" />
       </StyledCloseButton>
       <PageWrapper>
-        <Heading>Configuration </Heading>
+        <Heading>Configuration</Heading>
         {configFile ? (
           <PageDescription>
             This is a read-only representation of the Chromatic configuration options found in{" "}