Skip to content

Minor updates and fix to docker compose files #4567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

radeksm
Copy link

@radeksm radeksm commented May 17, 2025

Description of changes

  1. Set container hostname.
  2. Set container name (in output of docker ps/podman ps).
  3. Example how to set CHROMA_WORKERS.
  4. Set container time zone.
  5. Define healthcheck for the container.
  6. Adjust healthcheck timeouts, make sure: start_period > interval > (timeout*retries)
  7. Fix persistent volume path in docker-compose.yml.

Test plan

Build Chroma container image and tested all compose files.

1. Set container hostname.
2. Set container name (in output of docker ps/podman ps).
3. Example how to set CHROMA_WORKERS.
4. Set container time zone.
5. Define healthcheck for the container.
6. Adjust healthcheck timeouts, make sure: start_period > interval > (timeout*retries)
7. Fix persistent volume path in docker-compose.yml.

Signed-off-by: Radoslaw Smigielski <[email protected]>
Copy link
Contributor

Docker Compose Configuration Improvements for ChromaDB

This PR updates several docker-compose configuration files to improve container management, monitoring, and persistence. Key improvements include proper container naming, hostname setting, timezone configuration, and healthcheck optimization. The PR also fixes an important issue with the persistent volume path in docker-compose.yml.

Key Changes:
• Fixed persistent volume path from '/data' to '/chroma/chroma/' in docker-compose.yml
• Added container naming and hostname settings
• Added CHROMA_WORKERS configuration example
• Improved healthcheck configuration with better timeout values
• Added timezone configuration

Affected Areas:
• docker-compose.yml
• docker-compose.server.example.yml
• docker-compose.test.yml
• docker-compose.test-auth.yml

This summary was automatically generated by @propel-code-bot

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant