-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ENH] Support regex for local Chroma #4527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[ENH] Support regex for local Chroma #4527
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Support Regex Filtering for Local Chroma This PR implements regular expression filtering support for local Chroma database. It enables the ability to search documents using regex patterns by implementing the previously unimplemented Regex and NotRegex operators in the SQLite metadata module and enabling the regex feature in SQLite. Key Changes: Affected Areas: This summary was automatically generated by @propel-code-bot |
Can you add a basic test for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, is regex impl here a full scan?
Please add basic tests at the python side, also does js client support this? |
Yes this will be a scan on the document index |
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?