-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ENH]: add operator for garbage collection to list all files used by collection version #4466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
8e4042e
to
34ed231
Compare
0c85b47
to
b989fec
Compare
Add Operator to List All Files Used by a Collection Version (for Garbage Collection) This PR introduces a new garbage collection operator that, given a collection version file and version number, enumerates all file paths associated with that collection version, including block files (by traversing sparse indices), HNSW index files, and sparse index files. Additionally, it registers the new operator in the module system and improves RootManager's debug output by implementing a Debug trait. Key Changes: Affected Areas: This summary was automatically generated by @propel-code-bot |
34ed231
to
9ca2cd5
Compare
b989fec
to
b793a23
Compare
9ca2cd5
to
0725564
Compare
b793a23
to
282d440
Compare
0725564
to
dd8eba1
Compare
282d440
to
c0389ea
Compare
dd8eba1
to
d7546c4
Compare
c0389ea
to
8b8f1bf
Compare
d7546c4
to
8242dc4
Compare
8b8f1bf
to
9853786
Compare
8242dc4
to
5f592dc
Compare
9853786
to
fc1cd49
Compare
5f592dc
to
3c829d0
Compare
fc1cd49
to
c9ec71e
Compare
3c829d0
to
8fa48f8
Compare
c9ec71e
to
d357155
Compare
8fa48f8
to
c69db1a
Compare
8fe5f2f
to
afda731
Compare
7a408ad
to
c3dbe3a
Compare
afda731
to
1ea19ad
Compare
c3dbe3a
to
40357ea
Compare
1ea19ad
to
e949621
Compare
40357ea
to
aa00a67
Compare
e949621
to
91a3c81
Compare
aa00a67
to
a124ff5
Compare
version.version, | ||
collection_id, | ||
); | ||
tracing::trace!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why two traces here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they have different log levels
the second one is very verbose
91a3c81
to
f71445b
Compare
a124ff5
to
20cf4db
Compare
f71445b
to
c2e5444
Compare
20cf4db
to
100a8d5
Compare
56724a9
to
0197f05
Compare
100a8d5
to
9accc22
Compare
9accc22
to
4b76db0
Compare
0197f05
to
8fd33ad
Compare
4b76db0
to
43ad358
Compare
Merge activity
|
Description of changes
Does what the title says. Given a version file and a version, the operator constructs a complete list of files used by the collection version (including block files by traversing all sparse indices).
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustTested in the next PR.
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?
n/a