Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] New Embedding Function - VoyageAIEmbeddingFunction #1327

Closed
wants to merge 15 commits into from

Conversation

ha-sante
Copy link

@ha-sante ha-sante commented Nov 3, 2023

Description of changes

Summarize the changes made by this PR.

  • New functionality
    - Addition of VoyageAI to the list of embedding functions supported natively.

Test plan

How are these changes tested?

  • Executed Against py test_voyage_ef.py

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

github-actions bot commented Nov 3, 2023

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

chromadb/utils/embedding_functions.py Outdated Show resolved Hide resolved
chromadb/utils/embedding_functions.py Outdated Show resolved Hide resolved
@HammadB
Copy link
Collaborator

HammadB commented Dec 4, 2023

@ha-sante Would you be ok to make the texts -> input change?

@ha-sante
Copy link
Author

ha-sante commented Dec 4, 2023

Thanks for the recall @HammadB - will resubmit the changes before tomorrow ending gmt. - Thanks

@ha-sante ha-sante requested a review from HammadB December 5, 2023 19:19
@tazarov
Copy link
Contributor

tazarov commented Apr 7, 2024

@ha-sante, thank you so much for the hard work. With your permission, I'll do the following:

  • Rebase so we don't have conflicts
  • Add JS support (unless already done in a separate PR)
  • Add tests for both Python and JS (unless already part of another PR)

@ha-sante
Copy link
Author

ha-sante commented Apr 7, 2024

@tazarov You have my permission 👍

@tazarov tazarov self-assigned this Apr 7, 2024
@tazarov tazarov changed the title New Embedding Function - VoyageAIEmbeddingFunction [ENH]: New Embedding Function - VoyageAIEmbeddingFunction Apr 8, 2024
@tazarov tazarov changed the title [ENH]: New Embedding Function - VoyageAIEmbeddingFunction [ENH] New Embedding Function - VoyageAIEmbeddingFunction Apr 8, 2024
tazarov added 2 commits April 8, 2024 08:20
- Updated the EF to the latest API
- Added a few more options
- Tests
- Updated API key to be VOYAGE_API_KEY
- Test cleanup
@tazarov tazarov mentioned this pull request Apr 8, 2024
1 task
@tazarov
Copy link
Contributor

tazarov commented Apr 8, 2024

Related PR - #1871. I asked the OP to only merge the JS functionality

@nikhil-swamix
Copy link

merge it man, feature is more important than minor inconsistencies. atleast chroma dev branch should be have canary like releases.
fast. thanks.

@nikhil-swamix
Copy link

Hi , please merge, im having to write seperate utils for the same, and code is getting scattered.

@tazarov
Copy link
Contributor

tazarov commented May 20, 2024

@nikhil-swamix, thank your patience and hard work. We are refactoring the EFs, and I'll get back to you within the week.

@nikhil-swamix
Copy link

@nikhil-swamix, thank your patience and hard work. We are refactoring the EFs, and I'll get back to you within the week.

thanks very much! your commitment to opensource is helping thousands.

# Conflicts:
#	chromadb/utils/embedding_functions.py
@tazarov tazarov added the EF Embedding Functions label Jun 21, 2024
@tazarov
Copy link
Contributor

tazarov commented Jun 21, 2024

@atroyn, this is rebased and tested, and the docs are updated.

@atroyn atroyn self-requested a review June 25, 2024 00:48
@jeffchuber jeffchuber mentioned this pull request Sep 15, 2024
@jeffchuber
Copy link
Contributor

Our underlying impl has changed and so this PR is not landable as is.

That being said - we'd still like to add this functionality and that is now tracked in this issue.

@jeffchuber jeffchuber closed this Sep 15, 2024
@nikhil-swamix
Copy link

Our underlying impl has changed and so this PR is not landable as is.

That being said - we'd still like to add this functionality and that is now tracked in this issue.

Im really concerned, the way chroma is heading. so this guy's few hour effort for PR is now garbage. which would handicap lot of enthusiasts and scared from contributing. i have most utils seperately written just as inbuilt stuffs just break or show type error/mismatch with new versions. no offence just my perspective. regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EF Embedding Functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants