Fix many deprecation warnings, tests #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes all the deprecations in the form:
language_filter/test/lib/language_filter/version_test.rb:6. Use _(obj).wont_be_nil instead. This will fail in Minitest 6.
File.exists? is a deprecated name, use File.exist? instead
We don't need to use attr_accessor to handle assignment when we define a method_name= method in the class that will override it. language_filter/lib/language_filter.rb:44: warning: method redefined; discarding old matchlist= language_filter/lib/language_filter.rb:54: warning: method redefined; discarding old exceptionlist= language_filter/lib/language_filter.rb:62: warning: method redefined; discarding old replacement=
lib/language_filter.rb:184: warning: assigned but unused variable - first_char_done
|
Any chance of a merge/release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small modernisations and deprecation fixes. Each commit makes sense in isolation and should be fairly self-explanatory.
Includes a fix for the tests which were failing.