Make sure to store unknown bank as NULL in the database, and not as 0…

…. And make sure to not call numberFromDump() for non single program dumps.
christofmuc · Nov 2, 2024 · ff5db73 · ff5db73
1 parent 2631a43
commit ff5db73
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/MidiKraft b/MidiKraft
diff --git a/adaptations/GenericProgramDumpCapability.cpp b/adaptations/GenericProgramDumpCapability.cpp
@@ -102,6 +102,9 @@ namespace knobkraft {
 
 	MidiProgramNumber GenericProgramDumpCapability::getProgramNumber(const std::vector<MidiMessage>& message) const
 	{
+        if (!isSingleProgramDump(message)) {
+            return MidiProgramNumber::invalidProgram();
+        }
 		py::gil_scoped_acquire acquire;
 		if (me_->pythonModuleHasFunction("numberFromDump")) {
 			try {