[auto release] Trying to get the release upload to target the same re…

…lease as the release creation. Else I make releases without any binary files, which is a bit useless.
christofmuc · Jul 13, 2023 · c453197 · c453197
1 parent 4fa99b4
commit c453197
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/.github/workflows/builds-macos.yml b/.github/workflows/builds-macos.yml
@@ -47,5 +47,4 @@ jobs:
       with:
         file: build/KnobKraft_Orm-${{env.ORM_VERSION}}-Darwin.dmg
         tags: true
-        draft: true
 
diff --git a/.github/workflows/builds-ubuntu.yml b/.github/workflows/builds-ubuntu.yml
@@ -41,7 +41,6 @@ jobs:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       with:
         file: builds/KnobKraft_Orm-${{env.ORM_VERSION}}-Linux.tar.gz
-
         tags: true
 
     - name: Setup Sentry CLI

diff --git a/.github/workflows/builds-windows.yml b/.github/workflows/builds-windows.yml
@@ -104,6 +104,15 @@ jobs:
           APPCAST_ACCESS_TOKEN: ${{ secrets.APPCAST_ACCESS_TOKEN }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
+      - name: Upload executable into release
+        uses: xresloader/upload-to-github-release@v1
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          file: Builds/The-Orm/knobkraft_orm_setup_${{env.ORM_VERSION}}.exe
+          tags: true
+
+
       - name: Delete key file
         if: startsWith(github.ref, 'refs/tags/')
         run: |

diff --git a/make_github_release.py b/make_github_release.py
@@ -19,7 +19,7 @@
 # Create a release payload with the release notes
 release_payload = {
     "tag_name": version,
-    "name": f"Version {version}",
+    "name": f"{version}",
     "body": release_notes,
     "draft": False,
     "prerelease": False