Skip to content

Commit

Permalink
[mac] Remove the default setup of the ICU_ROOT, this should now only …
Browse files Browse the repository at this point in the history
…be required when you build on the developer machine.
  • Loading branch information
christofmuc committed Apr 1, 2024
1 parent 59e935f commit b95ba8b
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ if(WIN32)
set(PYTHON_VERSION_TO_EMBED "${PYTHON_EMBEDDED_MAJOR}.${PYTHON_EMBEDDED_MINOR}")
set(PYTHON_VERSION_TO_COPY "${PYTHON_EMBEDDED_MAJOR}${PYTHON_EMBEDDED_MINOR}") # Note the missing dot
else()
set(PYTHON_VERSION_TO_EMBED "3.10" CACHE STRING "Specify which version of Python should be used for embedding.")
set(PYTHON_VERSION_TO_EMBED "3.9" CACHE STRING "Specify which version of Python should be used for embedding.")
endif()

# On Windows, we need to download external dependencies
Expand Down Expand Up @@ -101,7 +101,10 @@ IF (WIN32)
add_compile_options(/fsanitize=address)
endif()
ELSEIF(APPLE)
set(ICU_ROOT "/opt/homebrew/opt/icu4c")
# For Intel Macs:
# set(ICU_ROOT "/usr/local/opt/icu4c")
# For Apple silicon:
# set(ICU_ROOT "/opt/homebrew/opt/icu4c")
find_package(ICU REQUIRED data uc)

# Supress a warning from juce_TargetPlatform by letting it know the build type
Expand Down

0 comments on commit b95ba8b

Please sign in to comment.