Fix crash on exit due to Librarian of SettingsView not unregistering …

…its MidiMessage handlers, causing a crash on exit when the synths were destroyed but more MIDI message being received.
christofmuc · Aug 15, 2024 · 110fc21 · 110fc21
1 parent bf9cba3
commit 110fc21
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/MidiKraft b/MidiKraft
diff --git a/The-Orm/MainComponent.cpp b/The-Orm/MainComponent.cpp
@@ -588,6 +588,10 @@ MainComponent::~MainComponent()
 	UIModel::instance()->currentSynth_.removeChangeListener(this);
 
 	Logger::setCurrentLogger(nullptr);
+
+	// Make sure to destroy the UI before the synths in order to unregister all message handlers
+	patchView_.reset();
+	settingsView_.reset();
 }
 
 #ifdef USE_SPARKLE