Skip to content

Commit

Permalink
Remove some TODOs and update changelog for the 1.31 release
Browse files Browse the repository at this point in the history
  • Loading branch information
christianrowlands committed Nov 4, 2024
1 parent 76f2766 commit 0663a0f
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 4 deletions.
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
# Changelog

## [1.31](https://github.com/christianrowlands/android-network-survey/releases/tag/v1.31) - 2024-11-04

* UI updates throughout the app.
* Sets the nonTerrestrialNetwork field in the phone state message (MQTT, gRPC, CSV, and GeoPackage)
* Prevent a crash when viewing the GNSS UI when no GPS provider is available on the device.
* Upgrade to SDK 35 (Android 15).
* Leverage new Android 15 getRejectCause API.
* Prevent really small speed values so that they are not displayed in scientific notation in JSON messages.
* Add additional permission checks for the other paths that turn on CDR logging to improve the UX and prevent crashes.
* Go to the devices location when the tower map is first opened and the info dialog is accepted.

## [1.30.2](https://github.com/christianrowlands/android-network-survey/releases/tag/v1.30.2) - 2024-09-26

* Log the battery percentage in the device status message CSV file as an int instead of a protobuf value.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
/**
* Holds application-wide state.
* <p>
* TODO: This class was pulled from the GPS Test app and needs to be removed once all the usages of this class are updated/removed
* This class was pulled from the GPS Test app
*
* @author Sean J. Barbeau
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public void onCreate(@Nullable Bundle savedInstanceState)
{
super.onCreate(savedInstanceState);

Bundle args = getArguments(); // TODO WIP Test this getArguments with multiple SIM cards
Bundle args = getArguments();
//noinspection DataFlowIssue
subscriptionId = args.getInt(SUBSCRIPTION_ID_KEY, -1);
Timber.d("Retrieving the subscriptionId from the arguments. subscriptionId=%d", subscriptionId);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,7 @@ private boolean startConnection()
try
{
final ConnectionHandshakeGrpc.ConnectionHandshakeBlockingStub blockingStub = ConnectionHandshakeGrpc
.newBlockingStub(channel).withDeadlineAfter(10, TimeUnit.SECONDS); // TODO make the timeout a user preference
.newBlockingStub(channel).withDeadlineAfter(10, TimeUnit.SECONDS);

final ConnectionReply connectionReply = blockingStub.startConnection(ConnectionRequest.newBuilder().build());

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public class GnssFilterDialog extends DialogFragment
@Override
public Dialog onCreateDialog(Bundle savedInstanceState)
{
Bundle args = getArguments(); // TODO WIP Test this getArguments
Bundle args = getArguments();
String[] items = args.getStringArray(ITEMS);
mChecks = args.getBooleanArray(CHECKS);
if (savedInstanceState != null)
Expand Down

0 comments on commit 0663a0f

Please sign in to comment.