initRender options for better UX
#71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when maxFontSize is too bigger than optimized value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-wordcloudis so good because it automatically calulates the max size of font to show all words.But, it is too slow to loading if maxFontSize of
fontSizesoptions is too bigger. because it recurvely calll draw function to find the optimized max value of fontSize.So I propose
initRenderoptions ofReactWordcloud.initRenderoptions is drawing tag-cloud when first attempts during caclulate the maxFontSize. I think It's better user experiance than wating loading completed.