Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support updates on dupe partials #181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support updates on dupe partials #181

wants to merge 1 commit into from

Conversation

mgomes
Copy link
Contributor

@mgomes mgomes commented Apr 7, 2015

Fixes #180

@ajb
Copy link
Collaborator

ajb commented Apr 8, 2015

Thanks for taking a stab at this!

Before merging, this will need to have some tests to go along with it. I can try to review this when I have some time, but I can't guarantee when that will be.

For now, if you need a quick fix in your app and you're not already doing so, so can simply copy over your modified sync.coffee.erb into your app/assets/javascripts/ folder, and Sprockets should use it instead of the file from inside of the gem.

@mgomes
Copy link
Contributor Author

mgomes commented Apr 8, 2015

I didn't see any JS testing being done for the gem. Is it in the dummy rails app somewhere?

The fix ended up being really minor. Basically using jquery's replaceAll vs replaceWith.

@ajb ajb mentioned this pull request Feb 6, 2016
Closed
@ajb ajb modified the milestone: 2.0 Feb 12, 2016
@mgomes
Copy link
Contributor Author

mgomes commented Mar 4, 2016

What's the plan for 2.0? Seems far off. Is there anything you are waiting on from me to get this merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Duplicate Partials Fail to Update
2 participants
@mgomes @ajb