Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for error handling #16

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

chrischtel
Copy link
Owner

@chrischtel chrischtel commented Jan 29, 2025

TL;DR

Added network output handler with test coverage for initialization and deinitialization

What changed?

  • Added network module export in nexlog.zig
  • Implemented test case for NetworkHandler initialization in network.zig
  • Created new network_tests.zig file with comprehensive handler testing
  • Added validation for endpoint configuration and buffer initialization

How to test?

  1. Run the test suite using zig test
  2. Verify NetworkHandler initialization with example.com:8080
  3. Check buffer size and endpoint configuration assertions
  4. Confirm proper deinitialization of resources

Why make this change?

To ensure the network output handler is properly tested and validated, providing confidence in its initialization, configuration handling, and resource management. This is crucial for maintaining reliability when sending logs over network connections.

Copy link
Owner Author

chrischtel commented Jan 29, 2025

Copy link
Owner Author

chrischtel commented Jan 29, 2025

Merge activity

  • Jan 29, 10:43 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 29, 10:46 AM EST: Graphite rebased this pull request as part of a merge.
  • Jan 29, 10:48 AM EST: A user merged this pull request with Graphite.

@chrischtel chrischtel changed the base branch from fix/ensureConnection-error-handling to graphite-base/16 January 29, 2025 15:43
@chrischtel chrischtel changed the base branch from graphite-base/16 to develop January 29, 2025 15:45
@chrischtel chrischtel force-pushed the 01-29-added_unit_tests_for_error_handling branch from f69a787 to e458190 Compare January 29, 2025 15:46
@chrischtel chrischtel merged commit 91bba34 into develop Jan 29, 2025
0 of 6 checks passed
@chrischtel chrischtel deleted the 01-29-added_unit_tests_for_error_handling branch January 31, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant