Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed unauthorizedResponse #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed unauthorizedResponse #166

wants to merge 1 commit into from

Conversation

sebzap
Copy link

@sebzap sebzap commented Sep 2, 2019

during the upgrade from 3.* to 4.* the unauthorised response changed from

[
    'error' => [
        'code' => 'GEN-UNAUTHORIZED',
        'http_code' => 401,
        'message' => 'Unauthorized'
    ]
]

to

[
    'error' => [
        'code' => '401',
        'http_code' => 'GEN-UNAUTHORIZED',
        'message' => 'Unauthorized.'
    ]
]

However it makes more sense that 401 is the http_code not code (and also an int)
(The upgrade also added a . at the end of the message, which is IMHO a valid change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant