Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow specifying config file location #522

Merged
merged 2 commits into from
Oct 24, 2024
Merged

allow specifying config file location #522

merged 2 commits into from
Oct 24, 2024

Conversation

chris48s
Copy link
Owner

@chris48s chris48s commented Oct 21, 2024

Closes #512

This can't be a command line argument.
Plugins can register command line flags. That means we need to load plugins before we can parse args, which in turn means we have to parse the config file before we can parse args.
So in order to provide this, we make the setting an env var.

TODO:

  • Manual testing for loading config files from arbitrary locations (particularly focussing on relative schema locations)
  • Write new unit tests covering this functionality
  • Decide if this is a breaking change or not. My gut instinct is it is not, but if it is, batch this up with other breaking changes you want to make into a new major

src/bootstrap.js Outdated Show resolved Hide resolved
@chris48s
Copy link
Owner Author

I think given v8r<=4.1.0 would only look for a config file in cwd, changing relative paths from being resolved relative to the config file location to being resolved relative to cwd makes no difference to any existing user. This can go into 4.2.0

@chris48s chris48s changed the title WIP allow specifying config file location allow specifying config file location Oct 23, 2024
@chris48s chris48s marked this pull request as ready for review October 23, 2024 19:23
@chris48s chris48s merged commit 4402485 into main Oct 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a CLI argument to specify the configuration file
1 participant