fix mocha/ line errors

chris48s · May 13, 2024 · 094d568 · 094d568
1 parent e492b73
commit 094d568
Show file tree

Hide file tree

Showing 6 changed files with 120 additions and 33 deletions.
diff --git a/eslint.config.cjs b/eslint.config.cjs
@@ -25,6 +25,7 @@ module.exports = [
       "prettier/prettier": ["error"],
       "mocha/no-skipped-tests": ["error"],
       "mocha/no-exclusive-tests": ["error"],
+      "mocha/max-top-level-suites": ["off"],
     },
   },
 ];
diff --git a/src/ajv.spec.js b/src/ajv.spec.js
@@ -6,9 +6,19 @@ import { testCacheName, setUp, tearDown } from "./test-helpers.js";
 
 describe("_ajvFactory", function () {
   describe("schema drafts compatibility", function () {
-    const testCache = new Cache(flatCache.load(testCacheName), 3000);
-    beforeEach(() => setUp());
-    afterEach(() => tearDown());
+    let testCache;
+
+    before(function () {
+      testCache = new Cache(flatCache.load(testCacheName), 3000);
+    });
+
+    beforeEach(function () {
+      setUp();
+    });
+
+    afterEach(function () {
+      tearDown();
+    });
 
     it("should support draft-04", function () {
       const ajv = _ajvFactory(

diff --git a/src/cache.spec.js b/src/cache.spec.js
@@ -6,9 +6,19 @@ import { testCacheName, setUp, tearDown } from "./test-helpers.js";
 
 describe("Cache", function () {
   describe("fetch function", function () {
-    const testCache = new Cache(flatCache.load(testCacheName), 3000);
-    beforeEach(() => setUp());
-    afterEach(() => tearDown());
+    let testCache;
+
+    before(function () {
+      testCache = new Cache(flatCache.load(testCacheName), 3000);
+    });
+
+    beforeEach(function () {
+      setUp();
+    });
+
+    afterEach(function () {
+      tearDown();
+    });
 
     it("should use cached response if valid", async function () {
       nock("https://www.foobar.com").get("/baz").reply(200, { cached: false });
@@ -38,9 +48,19 @@ describe("Cache", function () {
   });
 
   describe("cyclic detection", function () {
-    const testCache = new Cache(flatCache.load(testCacheName), 3000);
-    beforeEach(() => setUp());
-    afterEach(() => tearDown());
+    let testCache;
+
+    before(function () {
+      testCache = new Cache(flatCache.load(testCacheName), 3000);
+    });
+
+    beforeEach(function () {
+      setUp();
+    });
+
+    afterEach(function () {
+      tearDown();
+    });
 
     it("throws if callLimit is exceeded", async function () {
       const mock = nock("https://www.foobar.com")
@@ -63,9 +83,19 @@ describe("Cache", function () {
   });
 
   describe("expire function", function () {
-    const testCache = new Cache(flatCache.load(testCacheName), 3000);
-    beforeEach(() => setUp());
-    afterEach(() => tearDown());
+    let testCache;
+
+    before(function () {
+      testCache = new Cache(flatCache.load(testCacheName), 3000);
+    });
+
+    beforeEach(function () {
+      setUp();
+    });
+
+    afterEach(function () {
+      tearDown();
+    });
 
     it("should delete expired and malformed cache objects", async function () {
       const now = Date.now();

diff --git a/src/catalogs.spec.js b/src/catalogs.spec.js
@@ -118,9 +118,20 @@ describe("getMatchForFilename", function () {
       },
     },
   ];
-  const testCache = new Cache(flatCache.load(testCacheName), 3000);
-  beforeEach(() => setUp());
-  afterEach(() => tearDown());
+
+  let testCache;
+
+  before(function () {
+    testCache = new Cache(flatCache.load(testCacheName), 3000);
+  });
+
+  beforeEach(function () {
+    setUp();
+  });
+
+  afterEach(function () {
+    tearDown();
+  });
 
   it("returns a schema when one match found", async function () {
     assert.deepStrictEqual(

diff --git a/src/cli.spec.js b/src/cli.spec.js
@@ -18,7 +18,7 @@ import { dump as dumpToYaml } from "js-yaml";
 
 describe("CLI", function () {
   // Mock the catalog validation schema
-  beforeEach(() => {
+  beforeEach(function () {
     nock.disableNetConnect();
     nock("https://json.schemastore.org")
       .persist()
@@ -52,8 +52,11 @@ describe("CLI", function () {
       properties: { num: { type: "number" } },
     };
 
-    beforeEach(() => setUp());
-    afterEach(() => {
+    beforeEach(function () {
+      setUp();
+    });
+
+    afterEach(function () {
       tearDown();
       nock.cleanAll();
     });
@@ -460,10 +463,18 @@ describe("CLI", function () {
       type: "object",
       properties: { num: { type: "number" } },
     };
-    const yamlSchema = dumpToYaml(schema);
 
-    beforeEach(() => setUp());
-    afterEach(() => {
+    let yamlSchema;
+
+    before(function () {
+      yamlSchema = dumpToYaml(schema);
+    });
+
+    beforeEach(function () {
+      setUp();
+    });
+
+    afterEach(function () {
       tearDown();
       nock.cleanAll();
     });
@@ -570,8 +581,13 @@ describe("CLI", function () {
   });
 
   describe("error handling, single file", function () {
-    beforeEach(() => setUp());
-    afterEach(() => tearDown());
+    beforeEach(function () {
+      setUp();
+    });
+
+    afterEach(function () {
+      tearDown();
+    });
 
     it("should return 1 if invalid response from schemastore", async function () {
       const mock = nock("https://www.schemastore.org")
@@ -880,8 +896,13 @@ describe("CLI", function () {
   });
 
   describe("multiple file processing", function () {
-    beforeEach(() => setUp());
-    afterEach(() => tearDown());
+    beforeEach(function () {
+      setUp();
+    });
+
+    afterEach(function () {
+      tearDown();
+    });
 
     it("should return 0 if all files are valid", async function () {
       return cli({
@@ -951,8 +972,13 @@ describe("CLI", function () {
   });
 
   describe("output formats", function () {
-    beforeEach(() => setUp());
-    afterEach(() => tearDown());
+    beforeEach(function () {
+      setUp();
+    });
+
+    afterEach(function () {
+      tearDown();
+    });
 
     it("should log errors in text format when format is text", async function () {
       return cli({
@@ -1019,8 +1045,11 @@ describe("CLI", function () {
   });
 
   describe("external reference resolver", function () {
-    beforeEach(() => setUp());
-    afterEach(() => {
+    beforeEach(function () {
+      setUp();
+    });
+
+    afterEach(function () {
       tearDown();
       nock.cleanAll();
     });

diff --git a/src/config.spec.js b/src/config.spec.js
@@ -175,8 +175,11 @@ describe("preProcessConfig", function () {
 });
 
 describe("getConfig", function () {
-  beforeEach(() => setUp());
-  afterEach(() => {
+  beforeEach(function () {
+    setUp();
+  });
+
+  afterEach(function () {
     tearDown();
   });
 
@@ -273,8 +276,11 @@ describe("getConfig", function () {
 describe("validateConfig", function () {
   const messages = {};
 
-  beforeEach(() => setUp(messages));
-  afterEach(() => {
+  beforeEach(function () {
+    setUp(messages);
+  });
+
+  afterEach(function () {
     tearDown();
   });