Spreading arguments for subscriptions, find with reactivity #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… source (temporary solution)
|
|
||
| return collection.fetch(); | ||
| // temp solution but a reactive one, however we can't mutate this |
There was a problem hiding this comment.
I understand that this would lead to a reactive array, but I'm not sure about my approach for reactivity in Vue yet. The plugin itself needs to handle the reactivity and not the consumer of the plugin. That's why I'm for now simply returning the plain array
|
I think since there has been no progress on reactivity I propose that this get's merged, since it indeed leads to a reactive vue (+nuxt) plugin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support spreading arguments for subscriptions, find method with reactive data-source (temporary solution)