Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logstash.js #19

Closed
wants to merge 1 commit into from
Closed

Conversation

jfstgermain
Copy link

Checking if socket.unref exists. In node 0.10 the CleartextStream object returned by tls.connect doesn't have an unref() function

See #18

in node 0.10 the CleartextStream object returned by tls.connect doesn't have an unref() function
@rossille
Copy link
Collaborator

hi @jfstgermain
First, thank you for this pull request and sorry for the late answer. I'm taking over management of this lib, since the author doesn't have the time to do it anymore.
I had to move the projet to https://github.com/transcovo/bunyan-logstash-tcp and add tests before being able to accept pull requests.
I think that this pull request is not needed anymore since I dropped the support of node 0.x in the 1.0.0 version, but please know that:

  • If you still need this, I can publish 1 more version of the 0.x vertion which still supports node 0.x with your change included
  • If you want to contribute to the project, I will be accepting pull requests on the new repo https://github.com/transcovo/bunyan-logstash-tcp

@rossille rossille closed this May 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants