Move interface destructors interfaces to implementation (#1059)

Move the implementation of the virtual destructors from their own cpp file into the cpp of the implementation. #1042
chreden · Nov 28, 2022 · 5a1211b · 5a1211b
1 parent baec97e
commit 5a1211b
Show file tree

Hide file tree

Showing 116 changed files with 211 additions and 657 deletions.
diff --git a/trlevel/ILevel.cpp b/trlevel/ILevel.cpp
diff --git a/trlevel/Level.cpp b/trlevel/Level.cpp
@@ -5,6 +5,10 @@
 
 namespace trlevel
 {
+    ILevel::~ILevel()
+    {
+    }
+
     namespace
     {
         const float PiMul2 = 6.283185307179586476925286766559f;

diff --git a/trlevel/trlevel.vcxproj b/trlevel/trlevel.vcxproj
@@ -179,7 +179,6 @@
   </ItemGroup>
   <ItemGroup>
     <ClCompile Include="Decrypter.cpp" />
-    <ClCompile Include="ILevel.cpp" />
     <ClCompile Include="Level.cpp" />
     <ClCompile Include="LevelVersion.cpp" />
     <ClCompile Include="stdafx.cpp">

diff --git a/trlevel/trlevel.vcxproj.filters b/trlevel/trlevel.vcxproj.filters
@@ -18,7 +18,6 @@
     <ClInclude Include="Decrypter.h" />
   </ItemGroup>
   <ItemGroup>
-    <ClCompile Include="ILevel.cpp" />
     <ClCompile Include="Level.cpp" />
     <ClCompile Include="trtypes.cpp" />
     <ClCompile Include="LevelVersion.cpp" />

diff --git a/trview.app/Camera/Camera.cpp b/trview.app/Camera/Camera.cpp
@@ -16,6 +16,10 @@ namespace trview
         }
     }
 
+    ICamera::~ICamera()
+    {
+    }
+
     Camera::Camera(const Size& size)
         : _view_size(size), _forward(Vector3::Forward), _up(Vector3::Down), _position(Vector3::Zero)
     {

diff --git a/trview.app/Camera/ICamera.cpp b/trview.app/Camera/ICamera.cpp
diff --git a/trview.app/Elements/Entity.cpp b/trview.app/Elements/Entity.cpp
@@ -58,6 +58,10 @@ namespace trview
         }
     }
 
+    IEntity::~IEntity()
+    {
+    }
+
     Entity::Entity(const IMesh::Source& mesh_source, const trlevel::ILevel& level, const trlevel::tr2_entity& entity, const IMeshStorage& mesh_storage, uint32_t index, bool is_pickup)
         : Entity(mesh_source, mesh_storage, level, entity.Room, index, entity.TypeID, entity.position(), entity.Angle, entity.Intensity2, is_pickup)
     {

diff --git a/trview.app/Elements/IEntity.cpp b/trview.app/Elements/IEntity.cpp
diff --git a/trview.app/Elements/ILevel.cpp b/trview.app/Elements/ILevel.cpp
diff --git a/trview.app/Elements/IRoom.cpp b/trview.app/Elements/IRoom.cpp
diff --git a/trview.app/Elements/IStaticMesh.cpp b/trview.app/Elements/IStaticMesh.cpp
diff --git a/trview.app/Elements/ITypeNameLookup.cpp b/trview.app/Elements/ITypeNameLookup.cpp
diff --git a/trview.app/Elements/Level.cpp b/trview.app/Elements/Level.cpp
@@ -14,6 +14,10 @@ using namespace DirectX::SimpleMath;
 
 namespace trview
 {
+    ILevel::~ILevel()
+    {
+    }
+
     Level::Level(const std::shared_ptr<graphics::IDevice>& device,
         const std::shared_ptr<graphics::IShaderStorage>& shader_storage,
         std::unique_ptr<trlevel::ILevel> level,

diff --git a/trview.app/Elements/Room.cpp b/trview.app/Elements/Room.cpp
@@ -35,6 +35,10 @@ namespace trview
         }
     }
 
+    IRoom::~IRoom()
+    {
+    }
+
     Room::Room(const IMesh::Source& mesh_source,
         const trlevel::ILevel& level, 
         const trlevel::tr3_room& room,

diff --git a/trview.app/Elements/StaticMesh.cpp b/trview.app/Elements/StaticMesh.cpp
@@ -6,6 +6,10 @@ namespace trview
 {
     using namespace DirectX::SimpleMath;
 
+    IStaticMesh::~IStaticMesh()
+    {
+    }
+
     StaticMesh::StaticMesh(const trlevel::tr3_room_staticmesh& static_mesh, const trlevel::tr_staticmesh& level_static_mesh, const std::shared_ptr<IMesh>& mesh, const std::shared_ptr<IMesh>& bounding_mesh)
         : _mesh(mesh),
         _visibility_min(level_static_mesh.VisibilityBox.MinX, level_static_mesh.VisibilityBox.MinY, level_static_mesh.VisibilityBox.MinZ),

diff --git a/trview.app/Elements/TypeNameLookup.cpp b/trview.app/Elements/TypeNameLookup.cpp
@@ -24,6 +24,10 @@ namespace trview
         }
     }
 
+    ITypeNameLookup::~ITypeNameLookup()
+    {
+    }
+
     TypeNameLookup::TypeNameLookup(const std::string& type_name_json)
     {
         auto json = nlohmann::json::parse(type_name_json.begin(), type_name_json.end());

diff --git a/trview.app/Geometry/IPicking.cpp b/trview.app/Geometry/IPicking.cpp
diff --git a/trview.app/Geometry/ITransparencyBuffer.cpp b/trview.app/Geometry/ITransparencyBuffer.cpp
diff --git a/trview.app/Geometry/Picking.cpp b/trview.app/Geometry/Picking.cpp
@@ -9,6 +9,10 @@ using namespace DirectX::SimpleMath;
 
 namespace trview
 {
+    IPicking::~IPicking()
+    {
+    }
+
     Picking::Picking(const Window& window)
         : _window(window)
     {

diff --git a/trview.app/Geometry/TransparencyBuffer.cpp b/trview.app/Geometry/TransparencyBuffer.cpp
@@ -9,6 +9,10 @@ using namespace DirectX::SimpleMath;
 
 namespace trview
 {
+    ITransparencyBuffer::~ITransparencyBuffer()
+    {
+    }
+
     TransparencyBuffer::TransparencyBuffer(const std::shared_ptr<graphics::IDevice>& device)
         : _device(device), _untextured(create_texture(*device, Colour::White))
     {

diff --git a/trview.app/Graphics/ILevelTextureStorage.cpp b/trview.app/Graphics/ILevelTextureStorage.cpp
diff --git a/trview.app/Graphics/IMeshStorage.cpp b/trview.app/Graphics/IMeshStorage.cpp
diff --git a/trview.app/Graphics/ISectorHighlight.cpp b/trview.app/Graphics/ISectorHighlight.cpp
diff --git a/trview.app/Graphics/ISelectionRenderer.cpp b/trview.app/Graphics/ISelectionRenderer.cpp
diff --git a/trview.app/Graphics/ITextureStorage.cpp b/trview.app/Graphics/ITextureStorage.cpp
diff --git a/trview.app/Graphics/LevelTextureStorage.cpp b/trview.app/Graphics/LevelTextureStorage.cpp
@@ -3,6 +3,10 @@
 
 namespace trview
 {
+    ILevelTextureStorage::~ILevelTextureStorage()
+    {
+    }
+
     LevelTextureStorage::LevelTextureStorage(const std::shared_ptr<graphics::IDevice>& device, std::unique_ptr<ITextureStorage> texture_storage, const trlevel::ILevel& level)
         : _texture_storage(std::move(texture_storage)), _version(level.get_version())
     {

diff --git a/trview.app/Graphics/MeshStorage.cpp b/trview.app/Graphics/MeshStorage.cpp
@@ -2,6 +2,10 @@
 
 namespace trview
 {
+    IMeshStorage::~IMeshStorage()
+    {
+    }
+
     MeshStorage::MeshStorage(const IMesh::Source& mesh_source, const trlevel::ILevel& level, const ILevelTextureStorage& texture_storage)
     {
         const uint32_t pointers = level.num_mesh_pointers();

diff --git a/trview.app/Graphics/SectorHighlight.cpp b/trview.app/Graphics/SectorHighlight.cpp
@@ -9,6 +9,10 @@ namespace trview
         const Color Highlight_Colour{ 1, 1, 0 };
     }
 
+    ISectorHighlight::~ISectorHighlight()
+    {
+    }
+
     SectorHighlight::SectorHighlight(const IMesh::Source& mesh_source)
         : _mesh_source(mesh_source)
     {

diff --git a/trview.app/Graphics/SelectionRenderer.cpp b/trview.app/Graphics/SelectionRenderer.cpp
@@ -36,6 +36,10 @@ namespace trview
         }; 
     }
 
+    ISelectionRenderer::~ISelectionRenderer()
+    {
+    }
+
     SelectionRenderer::SelectionRenderer(const std::shared_ptr<graphics::IDevice>& device, const std::shared_ptr<graphics::IShaderStorage>& shader_storage, std::unique_ptr<ITransparencyBuffer> transparency, const graphics::IRenderTarget::SizeSource& render_target_source)
         : _device(device), _transparency(std::move(transparency)), _render_target_source(render_target_source)
     {

diff --git a/trview.app/Graphics/TextureStorage.cpp b/trview.app/Graphics/TextureStorage.cpp
@@ -3,6 +3,10 @@
 
 namespace trview
 {
+    ITextureStorage::~ITextureStorage()
+    {
+    }
+
     TextureStorage::TextureStorage(const std::shared_ptr<graphics::IDevice>& device)
         : _device(device)
     {

diff --git a/trview.app/Menus/IUpdateChecker.cpp b/trview.app/Menus/IUpdateChecker.cpp
diff --git a/trview.app/Menus/UpdateChecker.cpp b/trview.app/Menus/UpdateChecker.cpp
@@ -8,6 +8,10 @@ namespace trview
         const DWORD id_update_available = 30000;
     }
 
+    IUpdateChecker::~IUpdateChecker()
+    {
+    }
+
     UpdateChecker::UpdateChecker(const Window& window)
         : MessageHandler(window)
     {

diff --git a/trview.app/Routing/Actions.cpp b/trview.app/Routing/Actions.cpp
@@ -3,6 +3,10 @@
 
 namespace trview
 {
+    IActions::~IActions()
+    {
+    }
+
     Actions::Actions(const std::string& actions_json)
     {
         auto json = nlohmann::json::parse(actions_json.begin(), actions_json.end());

diff --git a/trview.app/Routing/IActions.cpp b/trview.app/Routing/IActions.cpp
diff --git a/trview.app/Routing/IRoute.cpp b/trview.app/Routing/IRoute.cpp
diff --git a/trview.app/Routing/Route.cpp b/trview.app/Routing/Route.cpp
@@ -78,6 +78,10 @@ namespace trview
         }
     }
 
+    IRoute::~IRoute()
+    {
+    }
+
     Route::Route(std::unique_ptr<ISelectionRenderer> selection_renderer, const IWaypoint::Source& waypoint_source, const UserSettings& settings)
         : _selection_renderer(std::move(selection_renderer)), _waypoint_source(waypoint_source), _colour(settings.route_colour), _waypoint_colour(settings.waypoint_colour)
     {

diff --git a/trview.app/Settings/ISettingsLoader.cpp b/trview.app/Settings/ISettingsLoader.cpp
diff --git a/trview.app/Settings/IStartupOptions.cpp b/trview.app/Settings/IStartupOptions.cpp
diff --git a/trview.app/Settings/SettingsLoader.cpp b/trview.app/Settings/SettingsLoader.cpp
@@ -5,6 +5,10 @@
 
 namespace trview
 {
+    ISettingsLoader::~ISettingsLoader()
+    {
+    }
+
     void to_json(nlohmann::json& json, const UserSettings::RecentRoute& item)
     {
         json["route_path"] = item.route_path;
-Original file line number
+Diff line change
@@ Expand Up / @@ -16,6 +16,10 @@ namespace trview @@
             }
         }
+        ICamera::~ICamera()
+        {
+        }
         Camera::Camera(const Size& size)
             : _view_size(size), _forward(Vector3::Forward), _up(Vector3::Down), _position(Vector3::Zero)
         {
@@ Expand Down @@