Skip to content

Commit

Permalink
Remove the idea of just re-sorting transparency due to billboards (#96)
Browse files Browse the repository at this point in the history
Just do a full regenerate for now.
Also filters were wrong for some reason for some images
#95
  • Loading branch information
chreden authored Apr 9, 2018
1 parent e4f647c commit 4d3c5eb
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 9 deletions.
5 changes: 2 additions & 3 deletions trview/Level.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -173,11 +173,10 @@ namespace trview
}
}

if (_resort_transparency || _regenerate_transparency)
if (_regenerate_transparency)
{
// Sort the accumulated transparent triangles farthest to nearest.
_transparency->sort(camera.position());
_resort_transparency = false;
}

_regenerate_transparency = false;
Expand Down Expand Up @@ -314,6 +313,6 @@ namespace trview

void Level::on_camera_moved()
{
_resort_transparency = true;
_regenerate_transparency = true;
}
}
1 change: 0 additions & 1 deletion trview/Level.h
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,5 @@ namespace trview
std::unique_ptr<TransparencyBuffer> _transparency;

bool _regenerate_transparency{ true };
bool _resort_transparency{ true };
};
}
5 changes: 5 additions & 0 deletions trview/Viewer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,11 @@ namespace trview

const float Speed = 10;
_free_camera.move(movement * _timer.elapsed() * Speed);

if (_level)
{
_level->on_camera_moved();
}
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions trview/trview.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,8 @@
</ItemGroup>
<ItemGroup>
<Image Include="resources\buttonup.png" />
<Image Include="resources\check_off.png" />
<Image Include="resources\check_on.png" />
<Image Include="resources\checkoff.png" />
<Image Include="resources\checkon.png" />
<Image Include="resources\numericdown.png" />
<Image Include="resources\numericup.png" />
<Image Include="resources\tomb1.png" />
Expand Down
6 changes: 3 additions & 3 deletions trview/trview.vcxproj.filters
Original file line number Diff line number Diff line change
Expand Up @@ -271,13 +271,13 @@
<Image Include="resources\numericup.png">
<Filter>Resources</Filter>
</Image>
<Image Include="resources\check_off.png">
<Image Include="resources\buttonup.png">
<Filter>Resources</Filter>
</Image>
<Image Include="resources\check_on.png">
<Image Include="resources\checkon.png">
<Filter>Resources</Filter>
</Image>
<Image Include="resources\buttonup.png">
<Image Include="resources\checkoff.png">
<Filter>Resources</Filter>
</Image>
</ItemGroup>
Expand Down

0 comments on commit 4d3c5eb

Please sign in to comment.