perf: do nothing after clicking esc

chouchouji · Nov 11, 2024 · 5598c69 · 5598c69
1 parent 786356c
commit 5598c69
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -174,7 +174,7 @@
   "scripts": {
     "clean": "rimraf node_modules dist *.vsix",
     "postinstall": "simple-git-hooks",
-    "package": "rimraf *.vsix && pnpm vsce package --no-dependencies",
+    "package": "rimraf *.vsix && pnpm build && pnpm vsce package --no-dependencies",
     "release": "vr release --skip-npm-publish",
     "lint": "eslint src --fix",
     "format": "prettier . --write",

diff --git a/src/extension.ts b/src/extension.ts
@@ -11,7 +11,7 @@ import {
   NO_ANY_ALIAS,
   SYSTEM_ALIAS,
 } from './constants';
-import { isEmpty, isNonEmptyArray } from 'rattail';
+import { isNonEmptyArray } from 'rattail';
 import { getAliasName } from './utils';
 import { Alias } from './types';
 import storePath from './path';
@@ -74,10 +74,15 @@ class AliasView implements vscode.TreeDataProvider<AliasItem> {
   async addAlias() {
     const alias = await vscode.window.showInputBox({
       placeHolder: CREATE_ALIAS_PLACEHOLDER,
-      value: '',
+      value: undefined,
     });
 
-    if (isEmpty(alias)) {
+    // cancel input alias
+    if (alias === undefined) {
+      return;
+    }
+
+    if (!alias.length) {
       vscode.window.showErrorMessage(ALIAS_IS_NOT_EMPTY);
       return;
     }
@@ -122,7 +127,12 @@ class AliasView implements vscode.TreeDataProvider<AliasItem> {
       value: alias.data.value,
     });
 
-    if (isEmpty(command)) {
+    // cancel input command
+    if (command === undefined) {
+      return;
+    }
+
+    if (!command.length) {
       vscode.window.showErrorMessage(ALIAS_IS_NOT_EMPTY);
       return;
     }