Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv4 vs IPv6 selector upon SSHServer initiation #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codfant
Copy link

@codfant codfant commented Oct 12, 2017

This fixes a but where redhat/centos has IPv6 disabled and "OSError: [Errno 97] Address family not supported by protocol" is presented upon server initiation.

@choppsv1
Copy link
Owner

So usually binding to :: actually allows connections for both IPv4 and IPv6. This change would then default to only allowing IPv4 connections. Is the problem that we are not handling the errored return and then trying the next value (IPv4)?

@codfant
Copy link
Author

codfant commented Jan 16, 2018

If the attribute is over-written when the instance is called, then you can still use IPv6. There should be an exception handler in here to check for the OSError assertion, but it's your call if you want to discard the change. I've had to change this code around a bit for it to work in my environment (though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants