[FEAT] Support return_type as texts for direct text handling
#146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to the chunking modules, allowing them to return either chunks or raw texts based on a new parameter
return_type. Additionally, it includes validation checks for the new parameter and updates to the chunk creation logic to accommodate this change.New Feature: Return Type Parameter
src/chonkie/chunker/recursive.py: Addedreturn_typeparameter to the__init__method and included validation checks. Updated_recursive_chunkmethod to handle both "chunks" and "texts" return types. [1] [2] [3] [4] [5]src/chonkie/chunker/sdpm.py: Addedreturn_typeparameter to the__init__method and included validation checks. Updated_create_chunkmethod to handle both "chunks" and "texts" return types. [1] [2] [3] [4] [5]src/chonkie/chunker/semantic.py: Addedreturn_typeparameter to the__init__method and included validation checks. Updated_create_chunkmethod to handle both "chunks" and "texts" return types. [1] [2] [3] [4] [5] [6] [7]src/chonkie/chunker/sentence.py: Addedreturn_typeparameter to the__init__method and included validation checks. Updated_create_chunkmethod to handle both "chunks" and "texts" return types. [1] [2] [3] [4] [5] [6]src/chonkie/chunker/token.py: Addedreturn_typeparameter to the__init__method and included validation checks. Updatedchunkmethod to handle both "chunks" and "texts" return types. [1] [2] [3] [4] [5] [6]