-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for OpenMM namespace changes #304
Conversation
@jchodera Trying to fix the namespace issue but the errors I'm getting a weird, is this
That's the only thing I think that would be causing this that I have changed. |
I don't want to be the bottleneck in sorting this out---I'd work directly with @peastman and the OpenMM issue tracker to resolve this! |
It should be exactly the same object.
|
Okay so what I was doing isn't the source of the errors now in CI. So the last time CI ran and passed was October 29th 2020 It looks like the issue is some missing connect records in the pdb file. |
So I downgraded a few core packages where I thought this error could happen from
And thought it worked since tests passed but really what was happening was:
So without the logs from the old CI runs, I have no idea if things were passing because things were working, or these tests were just skipped. |
Shoot, sorry about this. We just need to stabilize the bleeding here so we can finish ripping |
Exactly, I'm going to do the minimal amount possible to get nightly openmm to work.
I can see some issues witht this logic: So I might need to look at what version of parmed is getting pulled in/install master for testing. |
Okay this is ready for review:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
@jchodera is there any other PRs or issues we should fix before cutting a release? |
@mikemhenry : If we're about to cut a new release, it would be good to squeeze in some deprecation warnings about force field generators that have migrated to |
Fixes #303: There are changes happening in the openmm namespace, this should allow us to take advantage of the backwards compatible changes in the name space.
Also the README was pointing to the wrong CI badge, fixing that as well in this PR