(#3327) Improves UX of Chocolatey Install without 4.8

[JPRuskin]

Description Of Changes

This commit introduces the idea that the dotnet installation needing a reboot should not immediately halt the Chocolatey installation, but instead proceed as far as possible - then prompt for a reboot without throwing.

Motivation and Context

The install script currently throws after dotnet 4.8 is installed, which requires the user reboot and then re-run the install script. This, at least, reduces the need for an additional step post-reboot.

Testing

1. Build or finagle Chocolatey package with updated setup functions
   I downloaded the Chocolatey 2.2.2 package and used 7zip to overwrite chocolateysetup.psm1 with my changes.
2. Download Install.ps1
3. Run Install.ps1 -ChocolateyDownloadUrl ~\Path\to\Choco.nupkg (after execution policy / unblocking files)

Operating Systems Testing

• Windows 2019 (without dotnet 4.8 installed)
  
• Windows 10 sandbox (with dotnet 4.8 available)
  
  (no change to output)
• Windows Server 2012 (with dotnet 4.8 available, and PowerShell v3)
  
• Windows Server 2012 (without dotnet 4.8, and PowerShell v3)
  

Change Types Made

• [ ] Bug fix (non-breaking change).
• Feature / Enhancement (non-breaking change).
• [ ] Breaking change (fix or feature that could cause existing functionality to change).
• [ ] Documentation changes.
• PowerShell code changes.

Change Checklist

• [?] Requires a change to the documentation.
  I am unsure if there is any reference to this behaviour in our documentation.
• Documentation has been updated.
• [ ] Tests to cover my changes, have been added.
• [ ] All new and existing tests passed?
• PowerShell code changes: PowerShell v2 compatibility checked visually but not by running it on an actual PSv2 system

Related Issue

Fixes #3327

[pauby]

PowerShell code changes: PowerShell v2 compatibility checked?

This needs to be checked. We still support PowerShell v2.

[JPRuskin]

PowerShell code changes: PowerShell v2 compatibility checked?

This needs to be checked. We still support PowerShell v2.

I see nothing in my changes that is incompatible, to my knowledge, but I haven't run it in PS v2.

[pauby]

I see nothing in my changes that is incompatible, to my knowledge, but I haven't run it in PS v2.

As belt and braces, can you please run it in PS v2?

Can you also ensure the script says 'Chocolatey CLI' and not 'Chocolatey'?

[JPRuskin]

Can you also ensure the script says 'Chocolatey CLI' and not 'Chocolatey'?

Just to be clear, do you mean updating all instances of "Chocolatey" to "Chocolatey CLI" across the installation, or just bits that I've touched for this PR?

Examples of "bits I've touched" (in yellow), all instances that are likely to want updating if we're going to make it consistent (orange), things unlikely in my opinion to want updating (red):

(just noticed that strictly that second to last orange one I did add, but I based that on an existing message - would update them both if that were needed)

[JPRuskin]

Can you also ensure the script says 'Chocolatey CLI' and not 'Chocolatey'?

@pauby Just chasing this up, as I'd like to try and get this merged before January.

[pauby]

Can you also ensure the script says 'Chocolatey CLI' and not 'Chocolatey'?

@pauby Just chasing this up, as I'd like to try and get this merged before January.

For consistency it would be good to change all of the Chocolatey mentions that mean Chocolatey CLI to Chocolatey CLI.

[JPRuskin]

So, having an unexpected issue running this on the Windows 2012 (with PowerShell 3, no 4.8) system I have access to:

Pretty neat!

That said, it does recover after the reboot.

I've not seen that issue before, even on other non-4.8 having systems. Any thoughts, @gep13? We thought it would be safe to run /version, but it seems not. 4.5.2 seems to be present on this system.

I still like this change, and would prefer to not run choco.exe /version before the reboot (on a reboot-needing run) if this is happening, rather than give up on it.

[pauby]

I wanted to highlight this issue here, which ist not fixed by this issue, but is related.

[pauby]

I still like this change, and would prefer to not run choco.exe /version before the reboot (on a reboot-needing run) if this is happening, rather than give up on it.

Could we detect Server 2012, put some words in a different colour (to highlight it - maybe Write-Warning) to say you'll get an error here, ignore it, reboot as normal and everything will be fine?

[JPRuskin]

Could we detect Server 2012, put some words in a different colour (to highlight it - maybe Write-Warning) to say you'll get an error here, ignore it, reboot as normal and everything will be fine?

We could indeed! I'll give that a go, and we can see if we think it's enough.

[gep13]

LGTM!

[gep13]

@JPRuskin I took the liberty of modifying your commit messages slightly (they were overrunning the standard that we use for commit messages) but other than that, this LGTM, and I will merge once the CI builds complete.