Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect deserialization from sliced arrays #249

Merged
merged 10 commits into from
Oct 26, 2024
Merged

Incorrect deserialization from sliced arrays #249

merged 10 commits into from
Oct 26, 2024

Conversation

chmp
Copy link
Owner

@chmp chmp commented Oct 22, 2024

See #248

  • Map
    • fixed
    • add test for non-supported list layouts (see below)
  • List
    • fixed
    • add test for unsupported list layouts (non-increasing offsets, with data for null values)
  • Binary - no changes required
  • Utf8 - no changes required
  • Dictionary
  • Union
    • no changes required for slicing
    • but the impl assumes no skipped values in the underlying arrays and should verify this
    • alternative design: track for each child array the current position and skip as necessary
    • Test with "malicious" examples e.g., build union array with skipped values, non-consecutive offsets, ...
  • Update changelog

@chmp chmp marked this pull request as ready for review October 22, 2024 20:43
@chmp chmp marked this pull request as draft October 22, 2024 20:56
@chmp chmp marked this pull request as ready for review October 23, 2024 19:26
@chmp chmp enabled auto-merge October 26, 2024 17:19
@chmp chmp merged commit 32c1e2d into main Oct 26, 2024
1 check passed
@chmp chmp deleted the fix/sliced-lists branch October 26, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant