Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing option for reading sequence as (Large)List #245

Merged

Conversation

jkylling
Copy link
Contributor

@jkylling jkylling commented Oct 8, 2024

No description provided.

Copy link
Owner

@chmp chmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! This change makes progress with #41. Really cool, that you made sure to keep the current default!

Could you add two more things?

  • Add a test with sequence_as_large_list = false? You could simply add a call to trace_from_samples with the correct TracingOptions here. See for example here
  • Add an entry to the change log describing your changes. Please also include yourself in the thanks section similar to previous release

As discussed below: it would also be cool, if you could use trace as instead of serialize as in the docs. But that's more nice to have :)

@jkylling jkylling force-pushed the add-sequence-as-large-list-to-tracing-option branch from 24d1f3c to df59cbf Compare October 9, 2024 10:24
@jkylling jkylling requested a review from chmp October 9, 2024 10:28
chmp added 2 commits October 9, 2024 17:33
Add backticks to types in Changelog
Change serialize -> trace in TracingOptions docs
Copy link
Owner

@chmp chmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. I took the liberty to add the back ticks to the Readme myself and to change "serialize" to "trace" in the docs

@chmp chmp merged commit 839d34b into chmp:main Oct 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants